Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
651 stars 324 forks source link

feat!: implement chat endpoint switch #905

Closed gaurarpit closed 1 month ago

gaurarpit commented 1 month ago

Purpose

Does this introduce a breaking change?

How to Test

poetry run pytest -m "not azure"

What to Check

Verify that the following are valid

Other Information

Conversation API works as before: image

github-actions[bot] commented 1 month ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code
   create_app.py137397%203, 208, 331
code/backend/batch/utilities/helpers
   env_helper.py1371092%228, 233–234, 237–239, 251, 255–257
code/backend/batch/utilities/helpers/config
   conversation_flow.py40100% 
TOTAL247367272% 

Tests Skipped Failures Errors Time
212 0 :zzz: 0 :x: 0 :fire: 11.966s :stopwatch:
cecheta commented 1 month ago

I think this should be marked as a breaking change

ross-p-smith commented 1 month ago

I think this should be marked as a breaking change

Because this is a breaking change - I think we link to a new page from this link A backend that mimics the [On Your Data] flow, with the ability to switch to a custom backend. This could then document what these two endpoints do

gaurarpit commented 1 month ago

I think this should be marked as a breaking change

Because this is a breaking change - I think we link to a new page from this link A backend that mimics the [On Your Data] flow, with the ability to switch to a custom backend. This could then document what these two endpoints do

That's a very good suggestion. Will get something updated on the documentation today.