fix: Fix computer vision for deployments

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.

https://azure.microsoft.com/products/search

MIT License

651 stars 324 forks source link

fix: Fix computer vision for deployments #919

Closed cecheta closed 1 month ago

cecheta commented 1 month ago

Purpose

This PR handles the conditional creation of the computer vision resource

Does this introduce a breaking change?

[ ] Yes
[x] No

How to Test

Deploy different configurations, with/without computer vision, code/docker

github-actions[bot] commented 1 month ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
TOTAL	2383	673	71%

report-only-changed-files is enabled. No files were changed during this commit :)

Tests	Skipped	Failures	Errors	Time
194	0 :zzz:	0 :x:	0 :fire:	12.244s :stopwatch:

cecheta commented 1 month ago

I am going to separate the re-formatting to a new PR

cecheta commented 1 month ago

So the problem was that we were assuming the presence of computer vision parameters?

Correct, but the module was being created conditionally

Error messages weren't clear at all