Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
638 stars 310 forks source link

fix: Add `max_tokens` to chat completions #934

Closed cecheta closed 1 month ago

cecheta commented 1 month ago

Purpose

Does this introduce a breaking change?

How to Test

adamdougal commented 1 month ago

Do we know why that's the default? Is it more expensive?

github-actions[bot] commented 1 month ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   llm_helper.py421173%40–41, 50, 61–62, 73, 86–87, 94, 113, 121
TOTAL243468471% 

Tests Skipped Failures Errors Time
202 0 :zzz: 0 :x: 0 :fire: 19.011s :stopwatch:
cecheta commented 1 month ago

Do we know why that's the default? Is it more expensive?

Not sure, seems to be just for vision