style: Create a pre-commit hook for checking snake casing of files.

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.

https://azure.microsoft.com/products/search

MIT License

656 stars 327 forks source link

style: Create a pre-commit hook for checking snake casing of files. #961

Closed gaurarpit closed 3 weeks ago

gaurarpit commented 1 month ago

Purpose

Create a pre-commit hook for checking snake casing of files

Does this introduce a breaking change?

[ ] Yes
[x] No

How to Test

Tested locally by manually changing file names and casing.

github-actions[bot] commented 1 month ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
TOTAL	2502	561	77%

report-only-changed-files is enabled. No files were changed during this commit :)

Tests	Skipped	Failures	Errors	Time
278	0 :zzz:	0 :x:	0 :fire:	34.320s :stopwatch:

ross-p-smith commented 1 month ago

I thought we spoke about this in Sprint Planning that this has no value.

gaurarpit commented 1 month ago

I thought we spoke about this in Sprint Planning that this has no value.

it was already done by then. It didn't take any extra effort after our session since morning.

adamdougal commented 3 weeks ago

I think it's probably worth leaving this out for now, maybe we can add it in if we start active work on this project again.

gaurarpit commented 3 weeks ago

I think it's probably worth leaving this out for now, maybe we can add it in if we start active work on this project again.

Sure, I agree with you. I'll abandon this PR for now.