Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
656 stars 327 forks source link

feat: Include images in call to LLM #971

Closed cecheta closed 1 month ago

cecheta commented 1 month ago

Required for #750

Purpose

Does this introduce a breaking change?

How to Test

github-actions[bot] commented 1 month ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/tools
   question_answer_tool.py700100% 
TOTAL249755977% 

Tests Skipped Failures Errors Time
277 0 :zzz: 0 :x: 0 :fire: 35.155s :stopwatch:
cecheta commented 1 month ago

Note that we ran into this issue where the LLM attempts to provide an answer from every image passed to the LLM, even if it's not relevant

Screenshot 2024-05-21 145846

This should be looked into during #964

adamdougal commented 1 month ago

Note that we ran into this issue where the LLM attempts to provide an answer from every image passed to the LLM, even if it's not relevant

Screenshot 2024-05-21 145846

This should be looked into during #964

Is this something to do with top_k? Or is this something we can tweak in the system prompt to say ignore anything not relevant?

cecheta commented 1 month ago

Note that we ran into this issue where the LLM attempts to provide an answer from every image passed to the LLM, even if it's not relevant Screenshot 2024-05-21 145846 This should be looked into during #964

Is this something to do with top_k? Or is this something we can tweak in the system prompt to say ignore anything not relevant?

I think it would need to be done in the prompt

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: