Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
656 stars 327 forks source link

fix: Remove duplicated citation #980

Closed Prashant-Microsoft closed 3 weeks ago

Prashant-Microsoft commented 1 month ago

Purpose

Web App: In the reference section we are getting duplicate documents and after fixing this bug will not receive any duplicate documents

Does this introduce a breaking change?

How to Test

If you type something on chat bot for e.g. "Summarize the Microsoft 10k document in 1 word" then we are getting the duplicates document in the reference section

What to Check

After receiving response from chatbot you can check the reference section and now the duplicate document should disappear

github-actions[bot] commented 1 month ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250256177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 :zzz: 0 :x: 0 :fire: 34.357s :stopwatch:
ross-p-smith commented 1 month ago

This is related to PSL-BUG-1745

Prashant-Microsoft commented 1 month ago

This appears to break the parsing and formatting of the citations, see the image below where [doc1] etc is outputted:

image

What it should look like (ideally without the duplicates):

image

Fixed :

image
github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: