search

Azure-Samples / cognitive-services-personalizer-samples

Samples for the Microsoft personalizer
MIT License
54 stars 76 forks source link

Web app sample - changes for tutorial #50

Closed diberry closed 4 years ago

diberry commented 4 years ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x ] Other... Please describe: visually highlight rewardActionId and remove _au from features passed to rank call

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

diberry commented 4 years ago

@mandyshieh @tyclintw please review @edjez This sample doesn't call reward. Is there a functional or conceptual reason for this? I'm not sure how instructive the sample is. Thoughts?

mandyshieh commented 4 years ago

LGTM

diberry commented 4 years ago

@tyclintw if you are happy with it, can you please merge #sign-off - not sure what your usual process is for this.