Azure-Samples / cognitive-services-quickstart-code

Code Examples used by the Quickstarts in the Cognitive Services Documentation
MIT License
351 stars 518 forks source link

Use AuthenticatePrediction instead of AuthenticateTraining #259

Closed gottagetgit closed 3 years ago

gottagetgit commented 3 years ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

There should be no difference to the output of this program. It's simply that two methods were created by the original author to AuthenticateTraining, and AuthenticatePrediction. But AuthenticatePrediction is never called. AuthenticateTraining is called twice.

Technically, we can remove one of the methods and rename the other. But perhaps there was an intention by the author to separate the two for some training purpose.

gottagetgit commented 3 years ago

Relates to issue #257

fsharpn00b commented 3 years ago

Hello @gottagetgit,

Thank you very much for this fix. The double call to AuthenticateTraining looks like a copy/paste error.