search

Azure-Samples / communication-services-ui-library-react-native

UI library sample for React Native Bridge
MIT License
10 stars 10 forks source link

[Feature] Added Support for Title and Subtitle #14

Closed jpeng-ms closed 1 year ago

jpeng-ms commented 1 year ago

Purpose

added support for 1.1.0 features

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

Mrayyan commented 1 year ago

Can you update this new title and subtitle info in the read me as well.

JoshuaLai commented 1 year ago

Tested and everything is working as expected. The launch method is getting rather larger we need a refactor task to clean all this up

jpeng-ms commented 1 year ago

Thanks, just created a new task under KTLO and I will be working on it next sprint