search

Azure-Samples / communication-services-ui-library-react-native

UI library sample for React Native Bridge
MIT License
10 stars 10 forks source link

[Refactor] Updated Launch Parameters #16

Closed jpeng-ms closed 1 year ago

jpeng-ms commented 1 year ago

Purpose

refactored launch parameters into - local, remote and localization options.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

palatter commented 1 year ago

@jpeng-ms The android bridging guide page also needs to be updated

@jpeng-ms Is there iOS documentation that needs to be updated along with this?

Mrayyan commented 1 year ago

@jpeng-ms The android bridging guide page also needs to be updated

@jpeng-ms Is there iOS documentation that needs to be updated along with this?

yes, the iOS one should be updated as well.

jpeng-ms commented 1 year ago

@jpeng-ms The android bridging guide page also needs to be updated

@jpeng-ms Is there iOS documentation that needs to be updated along with this?

yes, the iOS one should be updated as well.

updated for android, but I don't see any reference of launch parameters under iOS, are you talking about MSDoc?

Mrayyan commented 1 year ago

@jpeng-ms The android bridging guide page also needs to be updated

@jpeng-ms Is there iOS documentation that needs to be updated along with this?

yes, the iOS one should be updated as well.

updated for android, but I don't see any reference of launch parameters under iOS, are you talking about MSDoc?

No you are right. I thought there was reference in the iOS page. PR looks good 👍