search

Azure-Samples / container-apps-store-api-microservice

Sample microservices solution using Azure Container Apps, Dapr, Cosmos DB, and Azure API Management
MIT License
340 stars 420 forks source link

Update build workflow to use PACKAGES_TOKEN var #16

Closed greenie-msft closed 2 years ago

greenie-msft commented 2 years ago

Purpose

Update build workflow to use PACKAGES_TOKEN var for logging into GHCR so it has the right perms to push/pull from GHCR. The current secret.GITHUB_TOKEN only has read perms and was failing to publish the image.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
paulyuk commented 2 years ago

@jeffhollan you cool with this? LGTM

jeffhollan commented 2 years ago

Awesome thank you! LGTM