Azure-Samples / container-apps-store-api-microservice

Sample microservices solution using Azure Container Apps, Dapr, Cosmos DB, and Azure API Management
MIT License
340 stars 422 forks source link

Change private registry to false so it works with GitHub/Container Apps Tutorial #32

Open DanWahlin opened 2 years ago

DanWahlin commented 2 years ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

Updates a single line in deploy/main.bicep. Currently the GitHub tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash uses this repo to demonstrate GitHub Actions and Azure Container Apps. However, the deploy/main.bicep marks the GitHub registry for the package as true but it looks like that should be false.

This PR changes isPrivateRegistry to false in deploy/main.bicep.

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check