Incremental Tye Improvements - Githubissues

Azure-Samples / container-apps-store-api-microservice

Sample microservices solution using Azure Container Apps, Dapr, Cosmos DB, and Azure API Management

MIT License

340 stars 422 forks source link

Incremental Tye Improvements #6

Closed philliphoff closed 3 years ago

philliphoff commented 3 years ago

Purpose

Updates the Dev Container definition to use "Docker in Docker" to avoid quirks of Docker networks and host names when using Dapr and make use more consistent with "bare metal" use.
Updates the Go service to allow use of a dynamic port via the PORT environment variable.
Defines an ingress service when using Tye to make finding the frontend port easier.
Updates Tye service definitions to use dynamic application ports.

NOTE: Ideally the Dapr HTTP ports would be dynamic as well, but that requires later (as yet unreleased) builds of Tye.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Create a Codespace
NPM install the Node service
PIP install the Python service
Run Tye (tye run)

What to Check

Verify that the following are valid

The application starts and all operations (create order, get order status, get inventory status) succeed

jeffhollan commented 3 years ago

@philliphoff seriously this is amazing - thanks for taking the time here. Just tested in a codespace and worked great