Azure-Samples / contoso-real-estate

Intelligent enterprise-grade reference architecture for JavaScript, featuring OpenAI integration, Azure Developer CLI template and Playwright tests.
MIT License
866 stars 518 forks source link

HackTogether: Share Property to More social media #255

Closed john0isaac closed 1 year ago

john0isaac commented 1 year ago

Are you accessing the project from the GitHub Codespaces?

Describe the bug When you try to share a property, it directs you to X social media platform.

To Reproduce

  1. Open the Portal
  2. Click on any listing
  3. Click the share Icon

Expected behavior Show a pop up or bar with multiple platforms to select from. (e.g. Facebook, LinkedIn, WhatsApp, Messenger, Instagram, and Telegram) User selects the desired social media to share the property to.

Screenshots Listing Page Share Property image

X Platform Sign in Page image

anfibiacreativa commented 1 year ago

Thanks for reporting! We look forward to your PR!

john0isaac commented 1 year ago

@anfibiacreativa thank you!!

juliamuiruri4 commented 1 year ago

Hey @john0isaac - There is a participant interested in working on this issue. @GmausDev

Are you already working on this, or is there a possibility to team up with him?

john0isaac commented 1 year ago

@juliamuiruri4 Definitely yes, we can team up!

GmausDev commented 1 year ago

So @john0isaac How can we start?¿

john0isaac commented 1 year ago

@GmausDev Let's start by dividing the work into two steps: Step 1: Create a pop-up menu to choose the desired social media platform from when anyone clicks on the share icon. Step 2: Add other social media platforms to the pop-up menu.

Unfortunately, we can't both work on the menu at the same time as step 1 is a blocker for step 2 so, please choose a step to start working on and I will continue after you.

Note: If you choose step 1 I will be waiting for you to finish it. If you choose step 2 you will have to wait for me to finish step 1.

GmausDev commented 1 year ago

Okay ! @john0isaac
Yep I was thinking the same , create a simple pop up and then add a stylish link tree.

My main expertise its back end and not in jss or tss , Take the step 1 and I´ll take the 2 I thinks its be more easier.

What do you think?

john0isaac commented 1 year ago

@GmausDev Okay I will start working on it. When I finish I will let you know here.

bilalbyte commented 1 year ago

Hey can I join you guys, I am a beginner and want to contribute, @GmausDev @john0isaac

GmausDev commented 1 year ago

Also , we can use teams or whatever. Btw , I´ll be on it ^^.

@bilalbyte Maybe it´s not big enough but this hackathon its about contribute and colaborate! I had no problem but we need to figure out how to.

So @john0isaac what do you think?

bilalbyte commented 1 year ago

I will be so grateful @GmausDev , Teams is a good option

GmausDev commented 1 year ago

Also im with another bug, if @john0isaac and @juliamuiruri4 I can step out and you can take the second phase from john repo.

I had no problem and if you feel comfortable with this issue my part is yours.

If @juliamuiruri4 its agree with this assign @bilalbyte to this issue , pls.

Thanks!

john0isaac commented 1 year ago

@GmausDev that's fine I can work with @bilalbyte. @bilalbyte glad to work with you! 🤝🏼

@bilalbyte you can work on the same thing @GmausDev was going to work on as it will be an easy part and I can guide you through it.

@juliamuiruri4 please, assign @bilalbyte to this issue in addition to me and remove @GmausDev.

GmausDev commented 1 year ago

@john0isaac Removed :P. @bilalbyte Have fun!

Blackie360 commented 1 year ago

can you guys organize a google meet to help me start I don't how to start

bilalbyte commented 1 year ago

Thank you @john0isaac

john0isaac commented 1 year ago

@Blackie360 there are many online live sessions on Microsoft Reactor to guide you through your journey! check the posting here! => #236 Also, if you are looking for something to help you get started I would recommend checking this => https://github.com/Azure-Samples/contoso-real-estate/discussions/236#discussioncomment-6720718 Specifically, this video that guides you on how to get started => https://youtu.be/cAAE2LwwZEQ

john0isaac commented 1 year ago

Hey @bilalbyte, I created a pull request that will close this issue. I have set up everything for you to learn from and just copy and paste to add more platforms.

Once my pull request is merged I will include instructions for you to complete working from where I stopped!

Kagirim commented 1 year ago

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

Kagirim commented 1 year ago

Thanks! that will be of massive help as im kind of lost about how to collaborate on this issue

bilalbyte commented 1 year ago

Hey @bilalbyte, I created a pull request that will close this issue. I have set up everything for you to learn from and just copy and paste to add more platforms.

Once my pull request is merged I will include instructions for you to complete working from where I stopped!

Sure, I'll be waiting for that

john0isaac commented 1 year ago

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

@Kagirim Great question! You can check out this comment to know the answer. https://github.com/Azure-Samples/contoso-real-estate/discussions/236#discussion-5434154 image

to know which issues are available to work on check the issues tab. https://github.com/Azure-Samples/contoso-real-estate/issues

Kagirim commented 1 year ago

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

@Kagirim Great question! You can check out this comment to know the answer. #236 (comment) image

to know which issues are available to work on check the issues tab. https://github.com/Azure-Samples/contoso-real-estate/issues

Thank you @john0isaac i was referring to the development progress on this issue on the share button. I'd like to know which section has not been handled yet.

john0isaac commented 1 year ago

@Kagirim Follow this pull request -> https://github.com/Azure-Samples/contoso-real-estate/pull/300