search

Azure-Samples / contoso-real-estate

Intelligent enterprise-grade reference architecture for JavaScript, featuring OpenAI integration, Azure Developer CLI template and Playwright tests.
MIT License
889 stars 528 forks source link

chore: add batch call to get api/favorites #309

Closed GmausDev closed 1 year ago

GmausDev commented 1 year ago

I implement a batch call to the favorites call.

Now imagen

before imagen

PD: Im not to much into ts or angular , so maybe can be a better way to do this or pattern I mean usually i work as BackEnd in another languages and im not feel confident at all with this solution . Im open to do this in a different way. Just here to improve and learn 📟

it "solve " #167

GmausDev commented 1 year ago

Hi @sinedied As I say im not was confident at all , tss is not my expertise 📎. I suppose there is a better solutions because as you say the ngOnChanges do his magic but im not understand at all how to work on this , so I googled solutions. There is no more time and I have been raised this on the discussion this Chore and maybe someone bring a better solution.

I´ll consider this like a small patch and expect a refactor :p

Thank you for let me improve 😊

GmausDev commented 1 year ago

Umm , its done? @anfibiacreativa AzureDevOps its easier xD

anfibiacreativa commented 1 year ago

👌

Hi @anfibiacreativa I'm looking , is @manekinekko who approves this?

Current maintainers of the repo are @manekinekko, @sinedied and myself.