Azure-Samples / contoso-real-estate

Intelligent enterprise-grade reference architecture for JavaScript, featuring OpenAI integration, Azure Developer CLI template and Playwright tests.
MIT License
889 stars 528 forks source link

[Hack-together] (feat): allow users to see house rating from home page #322

Closed VictorCodebase closed 1 year ago

VictorCodebase commented 1 year ago

Are you accessing the project from the GitHub Codespaces?

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

I really hope its not too late to suggest a feature. I noticed its need when working on the other, thats why its really late

A little background

I noticed the need for this while working on the comment section. I needed to look for a well reviewed (lie 5 stars) place (like 5 stars) to see if the comment section was working as intended. I however ended up having to click listing after listing - waiting for screens to load just to get something as simple as its rating I then wondered how that may affect a user who wants a good house but has to go wait on multiple load screens.

This may not be very hard to implement; I should be done by the end of today. Hopefully😂🥲

Feature description

A Lising's rating is displayed nest to its name to allow users to make pick choices faster.

Screenshots

image

Screenshot 2023-08-30 174638

To view on Figma: https://www.figma.com/file/54sMZ0kHDvlandOk0unGvd/star-rating-on-home-page?type=design&node-id=1%3A2&mode=design&t=TITJ9syTibf0TcwD-1

response

Im more than open to suggestions on how to improve scss or any other aspect. Thanks!!

VictorCodebase commented 1 year ago

My PR is almost there. Should I submit it once done😃?

https://github.com/Azure-Samples/contoso-real-estate/assets/135356007/5341539f-2677-4c02-a6fd-d31dd68d1abf

VictorCodebase commented 1 year ago

My PR is officially ready; Im soo excited😅. I've not done unnecessary formatting.

Making it was a lot tougher than I imagined but it was for sure fun.

Should I submit the PR😃?

screenshots:

Screenshot 2023-08-31 082524

anfibiacreativa commented 1 year ago

Please yes, open your PR! Thank you!

anfibiacreativa commented 1 year ago

Closed. Out of scope.