search

Azure-Samples / contoso-real-estate

Intelligent enterprise-grade reference architecture for JavaScript, featuring OpenAI integration, Azure Developer CLI template and Playwright tests.
MIT License
858 stars 512 forks source link

docs: update README.md samples frontmatter #421

Closed anfibiacreativa closed 6 months ago

anfibiacreativa commented 8 months ago

This potentially fixes inclusion in sample's dir

diberry commented 8 months ago

@anfibiacreativa These changes would impact a customer's ability to find this sample. Were you guided to remove the name, and description by someone on the samples browser team?

anfibiacreativa commented 8 months ago

@anfibiacreativa These changes would impact a customer's ability to find this sample. Were you guided to remove the name, and description by someone on the samples browser team?

Hi @diberry, maybe the problem is different, but the sample is not currently showing in the site. I tried to validate some of the service tags with those of samples that are indeed being returned by a query. Please correct me if wrong and if you have a list of accepted tags we may have to verify we don't have some formatting typo...

diberry commented 8 months ago

I'm going to track it down.

From: Natalia Venditto @.> Sent: Monday, January 8, 2024 3:36 AM To: Azure-Samples/contoso-real-estate @.> Cc: Dina Berry (SHE/HER) @.>; Comment @.> Subject: Re: [Azure-Samples/contoso-real-estate] docs: update README.md samples frontmatter (PR #421)

@anfibiacreativahttps://github.com/anfibiacreativa These changes would impact a customer's ability to find this sample. Were you guided to remove the name, and description by someone on the samples browser team?

Hi Dina, maybe the problem is different, but the sample is not currently showing in the site. I tried to validate some of the service tags with those of samples that are indeed being returned by a query. Please correct me if wrong and if you have a list of accepted tags we may have to verify we don't have some formatting typo...

— Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/contoso-real-estate/pull/421#issuecomment-1880835763, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ5LRMYCLRQSYUYVBR364CLYNPK5XAVCNFSM6AAAAABBEQZIE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQHAZTKNZWGM. You are receiving this because you commented.Message ID: @.***>

diberry commented 7 months ago

I'm still tracking this down. The sample was ingested yesterday but it seems to have dropped off the repo.

anfibiacreativa commented 7 months ago

I'm still tracking this down. The sample was ingested yesterday but it seems to have dropped off the repo.

What's the current status?

diberry commented 7 months ago

The sample has been onboarded - https://learn.microsoft.com/en-us/samples/browse/?terms=contoso. You don't need this PR but if you feel it is more accurate, merge it.