search

Azure-Samples / contoso-real-estate

Intelligent enterprise-grade reference architecture for JavaScript, featuring OpenAI integration, Azure Developer CLI template and Playwright tests.
MIT License
858 stars 512 forks source link

chore: refactor and add new types in connection with payments scenario #456

Open ganitx opened 5 months ago

ganitx commented 5 months ago

This is a follow-up PR for #117—issue: #124. I did expand a little on the scope of this PR by moving the interfaces from the model folder to a separate folder so imports can be from a common source.

manekinekko commented 5 months ago

Thank you @gm-al for sending these changes. We'll review them asap and keep you posted.

manekinekko commented 5 months ago

@gm-al after chatting with the team, it looks like this PR introduced changes that are out of scope of the initial issue. Would you mind keeping only the Stripe enum types and revert all other changes?

enum ReservationStatus { 
  Pending = "pending", 
  Active = "active", 
  Cancelled = "cancelled" , 
  Archived = "archived" 
};
ganitx commented 4 months ago

Thank you @manekinekko for the update. Sure, I will look at this PR soon and revert the extra changes.

ganitx commented 4 months ago

hey @manekinekko sorry for the delay. I updated the PR, let me know if there is something else i need to adjust.