search

Azure-Samples / dab-azure-cosmos-db-nosql-quickstart

Quickstart application template for Data API builder and Azure Cosmos DB for NoSQL
MIT License
1 stars 1 forks source link

[BUG] Bicep contains cosmosdb but doesn't deploy it #1

Open sander1095 opened 4 months ago

sander1095 commented 4 months ago

Description

The bicep contains definitions for both Azure SQL and CosmosDB Nosql.

However, inspecting files like infra/app/database.bicep shows that this only deploys Azure SQL. In fact, I can not find any usage of the CosmosDB anywhere in bicep.

Repro steps

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

I would expect this repo to have NOTHING to do with Azure SQL. Instead, only cosmosdb should be used. The other example repo for dab-sql should use azure sql instead.

Screenshots

No response

Environment

No response

seesharprun commented 4 months ago

@sander1095, you're right. We're going to get a fix live for this. It was copied from the Azure SQL variant of the repo (azure-samples/dab-azure-sql-quickstart) and this must have been missed.

sander1095 commented 3 months ago

Hey @seesharprun , that's awesome to hear. I see there's already a draft PR.

Will this be merged/ready to deploy when cloned locally before the weekend? I got a livestream next week about DAB + GraphQL and I'd love to use this repo for some of that.

seesharprun commented 3 months ago

I don't know if I will have things finalized this week.

We do have other guides at https://aka.ms/dab-docs that could help with your event.

We have guides and tutorials there.

For example, https://learn.microsoft.com/en-us/azure/data-api-builder/quickstart-nosql

And there's four more code samples.