Azure-Samples / djangoapp

The polls app from the official Django tutorial, that demonstrates how to build data-driven Python apps in Azure App Service.
MIT License
54 stars 426 forks source link

Update views.py to fix 404 error caused by Question model not being updated #22

Closed charris-msft closed 3 years ago

charris-msft commented 3 years ago

Purpose

Question

This is the easy fix and Dan and I confirmed it works, but I'm wondering why don't we also need to update the Choice model?

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
pip install requirements
python manage.py runserver

What to Check

Verify that the following are valid

Other Information

Thanks @qubitron for the help!

qubitron commented 3 years ago

LGTM, please take a look @cephalin and/or @kraigb !

kraigb commented 3 years ago

Looks fine; merging.