Are these samples maintained?

SeanFeldman commented 4 years ago

It looks like the samples have not been updated in quite a while. Is it going to be updated or should it be deprecated and replaced with a different repo/samples?

ahamad-MS commented 4 years ago

Hello @SeanFeldman .. These are still valid samples and no deprecation is planned for them.

We are evaluating what additional info/samples are needed and we are adding it to our backlog for current semester. thanks

SeanFeldman commented 4 years ago

Thank you for the confirmation, @ahamad-MS. Current samples are all on the outdated NuGet packages. It would be good to have those up-to-date.

👍 for additional samples.

Leon99 commented 4 years ago

Not only those packages are outdated but the samples won't compile after upgrading the packages to the latest versions.

SeanFeldman commented 4 years ago

@Leon99, I've only verified 2 samples (EGManageTopicsAndEventSubscriptions and EGManageDomainsAndEventSubscriptions) and they worked as expected once were updated to the latest packages (not prerelease versions).

Leon99 commented 4 years ago

@SeanFeldman how did you upgrade Microsoft.Azure.Management.ResourceManager to a non-prerelease version? There's not a single release version for it on nuget.org.

SeanFeldman commented 4 years ago

My bad, that one has to be a -preview. Even though it's not a pre-released version. Raised an issue about it.

Leon99 commented 4 years ago

Thanks for responding so quickly!

Sadly, even without upgrading Microsoft.Azure.Management.ResourceManager, I'm getting several errors after upgrading the rest of the packages:

...\event-grid-dotnet-publish-consume-events\EGManageTopicsAndEventSubscriptions\EGManageTopicsAndEventSubscriptions\Program.cs(167,17,167,28): error CS0117: 'Topic' does not contain a definition for 'InputSchema'
...\event-grid-dotnet-publish-consume-events\EGManageTopicsAndEventSubscriptions\EGManageTopicsAndEventSubscriptions\Program.cs(167,31,167,42): error CS0103: The name 'InputSchema' does not exist in the current context
...\event-grid-dotnet-publish-consume-events\EGManageTopicsAndEventSubscriptions\EGManageTopicsAndEventSubscriptions\Program.cs(168,17,168,35): error CS0117: 'Topic' does not contain a definition for 'InputSchemaMapping'
...\event-grid-dotnet-publish-consume-events\EGManageTopicsAndEventSubscriptions\EGManageTopicsAndEventSubscriptions\Program.cs(189,17,189,36): error CS0117: 'EventSubscription' does not contain a definition for 'EventDeliverySchema'
...\event-grid-dotnet-publish-consume-events\EGManageTopicsAndEventSubscriptions\EGManageTopicsAndEventSubscriptions\Program.cs(189,39,189,58): error CS0103: The name 'EventDeliverySchema' does not exist in the current context

It's pretty easy to fix them, but slightly annoying experience nevertheless.

.csproj after upgrading:

<PackageReference Include="Microsoft.Azure.Management.EventGrid" Version="5.0.0" />
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />
<PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="5.2.7" />

SeanFeldman commented 4 years ago

@Leon99 both Microsoft.Azure.Management.EventGrid and Microsoft.Azure.Management.ResourceManager have to use the -preview version. I'm not sure what's going on with the release pipeline for Azure SDKs, but something is off. The issue I've raised is still in review, so hopefully, Microsoft will sort it out soon.

These are the package references that will work for you:

<PackageReference Include="Microsoft.Azure.Management.EventGrid" Version="5.3.2-preview" />
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.7.1-preview" />
<PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="5.2.7" />

Azure-Samples / event-grid-dotnet-publish-consume-events

Are these samples maintained? #20