Azure-Samples / fastapi-on-azure-functions

A sample to run a FastAPI app on Azure Functions
MIT License
94 stars 70 forks source link

Update devcontainer and azure.yaml #16

Closed pamelafox closed 1 year ago

pamelafox commented 1 year ago

Purpose

Two updates related to this sample's azd support:

1) Removed "github-cli" feature from Dev Container. It is no longer a dependency for the azd cli, so it's best to remove it to speed up time for Dev Container to build. 2) Added a template name to azure.yaml. This will allow for tracking of successful "azd up"s of this template in the azd dashboards.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

How to Test

azd pipeline config should still work. (That is what previously needed the github-cli)