Azure-Samples / iotedge-logging-and-monitoring-solution

IoT Edge Logging and Monitoring Solution (ELMS) is an architecture and sample cloud workflow that enables automated retrieval of logs and metrics from IoT Edge devices
MIT License
42 stars 22 forks source link

Support uploading logs from edge devices behind gateway #21

Open jacqueskang opened 2 years ago

jacqueskang commented 2 years ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

It seems that currently version of ELMS only supports retrieving logs from top-layer edge devices. InvokeUploadModuleLogs function invokes UploadModuleLogs with SasUrl of azure blob storage's public endpoint. According to this link to retrieve logs from devices behind gateway it should use something like "https://$upstream:8000/myBlobStorageName/myContainerName?SAS_key" instead.

It would be great if InvokeUploadModuleLogs could identify edge devices behind gateway (e.g., having a parent device) and generates appropriate sasUrl for them.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

rashmisingh622 commented 2 years ago

This is fixed.. the last PR that was merged(fixing the event hub api version) did it I guess. I had applied the change in my local branch, but I guess it wasn't working because the deployment template was referring to the template in this repository... Thank you so much!