search

Azure-Samples / jmeter-aci-terraform

Scalable cloud load/stress testing pipeline solution with Apache JMeter and Terraform to dynamically provision and destroy the required infrastructure on Azure.
MIT License
119 stars 99 forks source link

Python Script link is broken in https://docs.microsoft.com/en-us/samples/azure-samples/jmeter-aci-terraform/jmeter-aci-terraform/?source=docs #51

Closed lakshaykaushik closed 3 years ago

lakshaykaushik commented 3 years ago

Python Script link is broken in the document:

https://docs.microsoft.com/en-us/samples/azure-samples/jmeter-aci-terraform/jmeter-aci-terraform/?source=docs

Fixing the link.

fixes #52

lakshaykaushik commented 3 years ago

This PR aims to close issue https://github.com/Azure-Samples/jmeter-aci-terraform/issues/52

allantargino commented 3 years ago

Hi @lakshaykaushik! Thanks for the issue and the PR - but I can't reproduce the broken link. When I navigate to the mentioned doc on main, the link works for me:

image

The relative link translates to: https://github.com/Azure-Samples/jmeter-aci-terraform/blob/main/scripts/jtl_junit_converter.py

lakshaykaushik commented 3 years ago

Hey Allan, this works fine when user goes to the link via github, but when user goes via https://docs.microsoft.com/en-us/samples/azure-samples/jmeter-aci-terraform/jmeter-aci-terraform/?source=docs , the link seems to be broken. Let me know if you are able to observe this.

allantargino commented 3 years ago

LGTM, thanks @lakshaykaushik