search

Azure-Samples / key-vault-node-getting-started

Get started with key vault management in NodeJs
MIT License
18 stars 24 forks source link

Update README.md #5

Closed johnpapa closed 7 years ago

johnpapa commented 7 years ago

Updating for promises, arrow functions, let/const.

msftclas commented 7 years ago

@johnpapa, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

johnpapa commented 7 years ago

Hi @balajikris , we're trying to update the readme files of samples since we are linking to them more from the docs. Can you take a look at this please?

balajikris commented 7 years ago

LGTM. With this change, readme.md and actual code is out of sync, syntactically at least. Should there be a work item to upgrade the actual code in the sample to ES6 syntax ?

johnpapa commented 7 years ago

i think that would be nice. but not critical