search

Azure-Samples / kubernetes-offer-samples

Samples for creating an Azure Marketplace Kubernetes offer
MIT License
17 stars 27 forks source link

sample to illustrate Autoupgrade minor version as input #9

Closed atchutbarli closed 1 year ago

atchutbarli commented 1 year ago

t

Purpose

Take Autoupgrade minor version as input from createuidef and wire it to arm template

Does this introduce a breaking change?

no


## Pull Request Type
What kind of change does this Pull Request introduce?

<!-- Please check the one that applies to this PR using "x". -->

[ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other... Please describe:


## How to Test
*  Get the code

git clone [repo-address] cd [repo-name] git checkout [branch-name] npm install


* Test the code
<!-- Add steps to run the tests suite and/or manually test -->


## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->
RamyasreeChakka commented 1 year ago 
          "label": "Cluster Extension Details",

Can we change this to application details?

Refers to: samples/k8s-offer-azure-vote/createUIDefinition.json:158 in 138da6f. [](commit_id = 138da6f99e70a4db0a5b4918aedb831a8e534544, deletion_comment = False)

RamyasreeChakka commented 1 year ago 
              "allowedValues": [

please update the regions here as well

Refers to: samples/k8s-offer-azure-vote/createUIDefinition.json:11 in 138da6f. [](commit_id = 138da6f99e70a4db0a5b4918aedb831a8e534544, deletion_comment = False)