search

Azure-Samples / meanjs

A simple MEAN.js application that demonstrates how to build data-driven Node.js apps in Azure App Service
Other
32 stars 43 forks source link

node changed --debug to --inspect #3

Closed johnpapa closed 7 years ago

msftclas commented 7 years ago

@johnpapa, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

amarzavery commented 7 years ago

@prashanthmadi @cephalin - Please review and merge if everything looks good.

johnpapa commented 7 years ago

thanks.

let me know when we can get this merged, please.

prashanthmadi commented 7 years ago

I don't think we are using nodemon in production/ after deploying app to Azure. Check gulpfile.js

It would be more of for local dev purpose

johnpapa commented 7 years ago

Right. But it errors out now. This change will make it work locally. Hitch the docs tell people to do and now it fails.

prashanthmadi commented 7 years ago

@johnpapa can you use below repo meanwhile. I will check with @cephalin and update. https://github.com/prashanthmadi/mean

johnpapa commented 7 years ago

I think that fix is fine. Maybe do that here too

https://github.com/prashanthmadi/mean/blob/master/gulpfile.js#L53

prashanthmadi commented 7 years ago

Yep. I was planning to push whole code in that repo to this(as that repo has recent commits of Meanjs).

cephalin commented 7 years ago

@prashanthmadi We are not allowed to use personal repos in our docs.

Let me know if the changes here are sufficient and I'll merge.

prashanthmadi commented 7 years ago

@cephalin Can you merge content from below branch. https://github.com/prashanthmadi/mean