Azure-Samples / media-services-v3-dotnet

The projects in this repository show how to implement different Azure Media Services scenarios using the v3 version.
MIT License
58 stars 52 forks source link

Should add the write permission to vault #52

Closed ChoOo7 closed 2 years ago

ChoOo7 commented 2 years ago

Because of E2ETestConfigService.cs

await keyVaultClient.SetSecretAsync($"https://{this.keyVaultName}.vault.azure.net", "ClearKeyStreamingKey", Convert.ToBase64String(this.clearKeyStreamingKey)).ConfigureAwait(false);

Purpose

Does this introduce a breaking change?

[ ] Yes
[ X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

johndeu commented 2 years ago

Thanks, I'll have the dev that wrote this sample review the PR