Azure-Samples / media-services-v3-java

Azure Media Service v3 Java SDK samples
MIT License
8 stars 18 forks source link

Add authorityhost to connect to azure china #107

Closed LuBu0505 closed 2 years ago

LuBu0505 commented 2 years ago

Add authorityhost to connect to azure china

Purpose

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

johndeu commented 2 years ago

@LuBu0505 - Rejecting this one, as this sample is meant for all public Azure clouds including Azure China. We will add a code comment here instead to recommend that customers can change to the appropriate sovereign cloud region as needed.

johndeu commented 2 years ago

Recommend changing that line of code to include a code comment like the following instead.

.authorityHost(AzureAuthorityHosts.AZURE_PUBLIC_CLOUD) // update to use Azure Government or Azure China