search

Azure-Samples / media-services-v3-java

Azure Media Service v3 Java SDK samples
MIT License
8 stars 18 forks source link

LiveEventWithDVR and EncodingWithMESPredefinedPreset samples #2

Closed v-jizhang closed 5 years ago

v-jizhang commented 5 years ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
mvn compile exec:java

What to Check

Verify that the following are valid

Other Information

johndeu commented 5 years ago

@v-jizhang Let me know when you update the PR and commit your final edits and just tag this with #sign-off.

johndeu commented 5 years ago

I’m fine with the ingnite.mp4 for now. We can update that content at anytime and keep the name the same.

From: BrianBlum notifications@github.com Sent: Wednesday, June 19, 2019 9:38 AM To: Azure-Samples/media-services-v3-java media-services-v3-java@noreply.github.com Cc: John Deutscher John.Deutscher@microsoft.com; Assign assign@noreply.github.com Subject: Re: [Azure-Samples/media-services-v3-java] LiveEventWithDVR and EncodingWithMESPredefinedPreset samples (#2)

@BrianBlum commented on this pull request.

In VideoEncoding/EncodingWithMESPredefinedPreset/src/main/java/sample/EncodingWithMESPredefinedPreset.javahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure-Samples%2Fmedia-services-v3-java%2Fpull%2F2%23discussion_r295396494&data=02%7C01%7CJohn.Deutscher%40microsoft.com%7C3e7d3242813347cb2fc108d6f4d48733%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965590973345834&sdata=ireCO9W3c%2FYqRMdABjJgkGiMMylE212pa8PArj1kR7c%3D&reserved=0:

+import com.microsoft.azure.management.mediaservices.v2018_07_01.Transform;

+import com.microsoft.azure.management.mediaservices.v2018_07_01.TransformOutput;

+import com.microsoft.azure.management.mediaservices.v2018_07_01.implementation.MediaManager;

+import com.microsoft.azure.storage.StorageException;

+import com.microsoft.azure.storage.blob.BlobListingDetails;

+import com.microsoft.azure.storage.blob.CloudBlobContainer;

+import com.microsoft.azure.storage.blob.CloudBlockBlob;

+import com.microsoft.azure.storage.blob.ListBlobItem;

+import com.microsoft.rest.LogLevel;

+

+import org.joda.time.DateTime;

+

+public class EncodingWithMESPredefinedPreset {

Do you want to standardize the samples around a specific piece of content, named something like SDKSamples.mp4 rather than the Ignite.mp4 content? I haven't looked at the Ignite.mp4 content, so I don't know if it shows future features that have already made it into the product, or shows anyone who is no longer with the company. Anything but BigBuckBunny.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure-Samples%2Fmedia-services-v3-java%2Fpull%2F2%3Femail_source%3Dnotifications%26email_token%3DAAAJWIF4RJ6G7EAS6C2REXLP3JOHPA5CNFSM4HZEWMJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4BJIYQ%23discussion_r295396494&data=02%7C01%7CJohn.Deutscher%40microsoft.com%7C3e7d3242813347cb2fc108d6f4d48733%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965590973355830&sdata=gRbZou2Ae52xmqlFsYZLYaponr4YLQ803RcV1od4v%2FM%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAJWIC2T7DQ4AFDCMUHOYDP3JOHPANCNFSM4HZEWMJA&data=02%7C01%7CJohn.Deutscher%40microsoft.com%7C3e7d3242813347cb2fc108d6f4d48733%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965590973355830&sdata=URSQ7jsDe9j%2B3%2Fbpp7TjL9rVDtN5RdAmzA9YgohLXgI%3D&reserved=0.

v-jizhang commented 5 years ago

sign-off @johndeu Final edits done.

johndeu commented 5 years ago

Merged