Azure-Samples / modern-data-warehouse-dataops

DataOps for Microsoft Data Platform technologies. https://aka.ms/dataops-repo

MIT License

588 stars 459 forks source link

E2E Parking Sensor: Convert ARM templates to Bicep, Improve Deployment script, and bugfix #370 #378

Closed devlace closed 3 years ago

devlace commented 3 years ago

Type of PR

Documentation changes
Code changes
Test changes
CI-CD changes

Purpose: Improvements to Parking Sensor solution

Convert ARM templates to bicep.
Change how ADF authenticates to Databricks and Storage to use MSI instead of service principal.
Swap to KeyVault-backed Secret Scopes in Databricks now that it can be automated.
Improve Deployment script
- remove reliance of global environment variables for child scripts.
- simplify Databricks PAT generation script
- Fix shellcheck lint errors
Make deploy script idempotent
Improve cleanup script to list resources prior to deletion and prompt user.
Updates to the documentation

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[x] No PII in logs
[x] Made corresponding changes to the documentation

Validation steps

Deploy and validated:

Issues Closed or Referenced

Closes #370
Closes #376

promisinganuj commented 3 years ago

I am happy with the deployment.