ydaponte commented 3 years ago

Type of PR

Documentation changes
Code changes

Purpose

Adds the deployment of a Synapse workspace and a Synapse Spark Pool as a baseline to port the parking sensor sample to synapse

Does this introduce a breaking change? If yes, details on what can break

On the main.bicep file I'm referencing to a storage_v2.bicep module instead of the previous storage.bicep version.

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[ X] No PII in logs
[ X] Made corresponding changes to the documentation

Validation steps

Deployed the e2e sample with the changes, deployment was successful

Issues Closed or Referenced

Closes #385

devlace commented 3 years ago

@ydaponte Could you change the target branch to this feature branch: e2e/parking-sensors-add-synapse. That way we can collaborate on that and then merge to main once we get to v1 :)

devlace commented 3 years ago

Not to overcomplicate things -- but are we foreseeing the deploy.sh to deploy both the Synapse and Databricks versions of the solution? Or perhaps, should we prompt the user to deploy either the Synapse-flavour or the Databrick-flavour (current solution)?