Azure-Samples / modern-data-warehouse-dataops

DataOps for Microsoft Data Platform technologies. https://aka.ms/dataops-repo

MIT License

588 stars 459 forks source link

Fixes for deployment issues #419

Closed jmostella closed 3 years ago

jmostella commented 3 years ago

*.sh checkin execute flag
log_analytics.bicep add etag "*"
synapse.bicep make managed rg unique (${deployment_id})
.devcontainer/post_create.sh check in execute flag
devcontainer.json updated

Type of PR

Documentation changes
Code changes
Test changes
CI-CD changes
GitHub Template changes

Purpose

...

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[ ] No PII in logs
[ ] Made corresponding changes to the documentation

Validation steps

...

Issues Closed or Referenced

Closes #419 #418
References #issue_number

promisinganuj commented 3 years ago

Please check/set the execute permissions for "post_create.sh" as well, otherwise looks good

jmostella commented 3 years ago

Please check/set the execute permissions for "post_create.sh" as well, otherwise looks good

Its included in this change