Azure-Samples / modern-data-warehouse-dataops

DataOps for the Modern Data Warehouse on Microsoft Azure. https://aka.ms/mdw-dataops.

MIT License

570 stars 451 forks source link

Fixed error in parking_sensors/scripts/deploy_infrastructure.sh where… #532

Closed Illuminae closed 2 years ago

Illuminae commented 2 years ago

… the attribute for user id on the Microsoft Graph has changed from objectId to just id.

Type of PR

Code changes

Purpose

Yesterday I tried running the deployment and it failed as the objectId in the JSON returned by

az ad signed-in-user show --output json

has been renamed to "id". See https://github.com/Azure/azure-cli/issues/9506#issuecomment-1149942398

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[ ] Made corresponding changes to the documentation

Validation steps

...

Issues Closed or Referenced

Closes #issue_number
References #issue_number

devlace commented 2 years ago

Thanks @Illuminae for this and appreciate the PR. There were a few other places in the repo which needed changing to accommodate for this change so I've went ahead and made those changes in this PR: https://github.com/Azure-Samples/modern-data-warehouse-dataops/pull/547.