Azure-Samples / modern-data-warehouse-dataops

DataOps for Microsoft Data Platform technologies. https://aka.ms/dataops-repo
MIT License
588 stars 459 forks source link

Add Single Tech Sample for More Synapse Integration Testing #568

Closed kottofy closed 1 year ago

kottofy commented 1 year ago

Type of PR

Purpose

Adds a new single tech sample with additional Synapse integation tests and also can deploy to AzureUSGovernment cloud.

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

Validation steps

Follow steps in README

adrian-gonzalez commented 1 year ago

WHOOOOOO

image

promisinganuj commented 1 year ago

Hi @kottofy @mmclende, is this PR ready for DTD review. If not, please covert it to draft.

devlace commented 1 year ago

I ran into this error while trying to deploy the solution. Looks like it is missing the Trigger definition.

image

mmclende commented 1 year ago

@devlace We pushed some updates. Can you take a look when you get a chance?

devlace commented 1 year ago

I've tried deploying the sample and still running into an error. Looks like its a missing pipeline definition? image

mmclende commented 1 year ago

I've tried deploying the sample and still running into an error. Looks like its a missing pipeline definition? image

There's an issue where if there's no folder it is giving that issue. I had added READMEs to populate the folder on pull and just missed adding the readme to the last git oops. I pushed the change, can you try again?

thurstonchen commented 1 year ago

Dear colleagues,

I've tried deploying the sample and running into below error when starting Synapse pipeline trigger. (BTW, the previous issue has been fixed, thanks! : ) image

~~The debugging logs of relevant az synapse trigger start command shows there's RBAC issue, looks like we need to assign the Contributor role of related storage account to relevant SP, according to this document? Thanks for your help to take a look!~~

{
  "code": "BadRequest",
  "message": "The client 'xxx' with object id 'xxx' does not have authorization to perform action 'Microsoft.EventGrid/eventSubscriptions/write' over scope '/subscriptions/xxx/resourceGroups/mdwdops-mdwtc21-dev-rg/providers/Microsoft.Storage/storageAccounts/mdwdopsstdevmdwtc21/providers/Microsoft.EventGrid/eventSubscriptions/xxx' or the scope is invalid. If access was recently granted, please refresh your credentials.",
  "target": "T_Stor_mdwdops-mdwtc21-dev",
  "details": null,
  "error": null
}

UPDATED on Apr. 6th

Best, DataOps V-team

sweanan commented 1 year ago

hi @kottofy Just a small comment to update the documents for the below:

  1. when trying to run these integration test noticed that the Service principal created would require to have Storage Blob Data Contributor along with the owner role permissions.

  2. Also from the Synapse workspace we need to provide the [RBAC role assignments] (https://learn.microsoft.com/en-us/azure/synapse-analytics/security/how-to-manage-synapse-rbac-role-assignments) to this service principal

devlace commented 1 year ago

I tried deploying this and looks good to me! Thanks @thurstonchen and @sweanan for trying this out as well. @kottofy if you can do the quick update to the docs as Sweanan suggested, I'm happy to merge this.