Azure-Samples / modern-data-warehouse-dataops

DataOps for the Modern Data Warehouse on Microsoft Azure. https://aka.ms/mdw-dataops.
MIT License
570 stars 451 forks source link

upload config file for data retention #591

Closed elenaterenzi closed 1 year ago

elenaterenzi commented 1 year ago

Type of PR

Purpose

Data Retention - add configuration file as part of the deployment steps

Author pre-publish checklist

Validation steps

Issues Closed or Referenced

elenaterenzi commented 1 year ago

because the pipeline will read with the M

The code is working well, beyond the comments I left there is one thing missing - probably you need to allow the MSI to read the config container and file, because the pipeline will read with the MSI. The MSI name is available as the WS name during the deployment, is just a matter of add it to the container and file (probably you will need to use the ACL CLI that we were discussing on the stand-up. Let me know if you have questions! And thank YOU!

There is already a role assignment as Storage Contributor to the Synapse worskpace MSI for the storage account where the config container lives, that should be enough I guess unless you want something else? note that you as a user won't have access to the container if that was your concern, in that case I can grant read access but I guess it would be better if end users don't have access to the config so we remove the possibility that they would not tamper with data lake ACLs?