issues
search
Azure-Samples
/
modern-data-warehouse-dataops
DataOps for the Modern Data Warehouse on Microsoft Azure. https://aka.ms/mdw-dataops.
MIT License
570
stars
451
forks
source link
Elena/597 add keyvault
#601
Closed
elenaterenzi
closed
1 year ago
elenaterenzi
commented
1 year ago
Type of PR
Code changes
CI-CD changes
Purpose
Add KeyVault
Store Keys from Stg account and AAD group name and id in KeyVault
deploy Linked Service for KeyVault
minor changes to other scripts and Linked Services json files
Does this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist
[ ] Added test to prove my fix is effective or new feature works
[x] No PII in logs
[ ] Made corresponding changes to the documentation
Validation steps
deploy via deploy.sh
verify a KeyVault is deployed in the rg
verify a new linked service for KeyVault is in Synapse and correctly connects
verify that the key vault contains keys for the stg account and AA group object ids
Issues Closed or Referenced
Closes #594
Type of PR
Purpose
Does this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist
Validation steps
Issues Closed or Referenced