Azure-Samples / modern-data-warehouse-dataops

DataOps for the Modern Data Warehouse on Microsoft Azure. https://aka.ms/mdw-dataops.
MIT License
570 stars 451 forks source link

feat: Add optional setup environment notebook for #653

Closed siliang-j-1225 closed 10 months ago

siliang-j-1225 commented 10 months ago

Add optional setup environment notebook for simplified Azure resource setup

Type of PR

Purpose

Add a SETUP_ENVIRONMENT.ipynb notebook to assist setting up environment.

Does this introduce a breaking change? If yes, details on what can break

No.

Author pre-publish checklist

Validation steps

Follow instructions in the notebook to create environment.

Issues Closed or Referenced

No.

siliang-j-1225 commented 10 months ago

Hi @siliang-j-1225, Thanks for the PR! Just two cents:

  • Maybe we change the notebook name to deploy.ipynb or _deploy_azureresources.ipynb? Just checked the naming convention for the IAC scripts of other samples in the MDW repo, and notice they normally call deploy.sh
  • Notice there're instructions in the first cell on how to run this notebook, how about we also mention that in README as well, so that audiences could know it before opening the notebook? Thanks! :- )

Thanks for the comment. Good points! I renamed SETUP_ENVIRONMENT.ipynb to deploy.ipynb, and updated related docs

thurstonchen commented 10 months ago

Thanks for the comment. Good points! I renamed SETUP_ENVIRONMENT.ipynb to deploy.ipynb, and updated related docs

Hi Siliang, Thanks for the quick updates! BTW, just added Anuj as reviewer to have the final check, thanks @promisinganuj ! :- )

siliang-j-1225 commented 10 months ago

as the branch feat/single-tech/feature_engineering_on_fabric is already merged(by PR https://github.com/Azure-Samples/modern-data-warehouse-dataops/pull/652), created new PR https://github.com/Azure-Samples/modern-data-warehouse-dataops/pull/654 here to merge the changes to main branch.