Azure-Samples / ms-identity-ciam-dotnet-tutorial

CIAM .NET samples
MIT License
25 stars 18 forks source link

Failed to find the placed holder mentioned iOS AppDelegate.cs file #43

Open rickgregorypf opened 10 months ago

rickgregorypf commented 10 months ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [X ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Refer to https://github.com/Azure-Samples/ms-identity-ciam-dotnet-tutorial/tree/main/1-Authentication/2-sign-in-maui#:~:text=Open%20the%20Platforms%5CiOS,from%20the%20Azure%20portal. A reference is made to the placeholder in the iOS AppDelegate.cs file. I do not see that placeholder.

Any log messages given by the failure

Expected/desired behavior

Adjust the AppDelegate.cs file to include the placeholder or adjust the step in the documentation.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?) iOS

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

jmprieur commented 10 months ago

@bgavrilMS do you mind taking this one?

bgavrilMS commented 10 months ago

I don't think any such update is needed. The clientId is known programatically, and injected in all the right places. Only the app manifests need to be updated.

https://github.com/Azure-Samples/ms-identity-ciam-dotnet-tutorial/blob/main/1-Authentication/2-sign-in-maui/Platforms/iOS/AppDelegate.cs