Azure-Samples / ms-identity-ciam-javascript-tutorial

CIAM JavaScript samples
MIT License
32 stars 40 forks source link

Dependency Update for Ch1 Vanilla JS #85

Closed BenBagBag closed 4 months ago

BenBagBag commented 4 months ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ x ] Other... Please describe: Dependency update

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

iambmelt commented 4 months ago

@BenBagBag - The diff for this PR is pretty noisy so I'm having trouble seeing where the differences are from main branch, are there specific sets of this change you want to call attention to for review?

BenBagBag commented 4 months ago

@iambmelt Sorry, that's due to the Git issue I mentioned in Teams. I put in comments to show where the changes happened. Shouldn't happen in future commits.

BenBagBag commented 4 months ago

@iambmelt and @hectormmg I do not have merge permissions. :)