Azure-Samples / ms-identity-ciam-javascript-tutorial

CIAM JavaScript samples
MIT License
26 stars 37 forks source link

update entra-previews links #98

Closed BenBagBag closed 2 months ago

BenBagBag commented 2 months ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

BenBagBag commented 2 months ago

@kengaderdus I have updated the links.

For the wording, your suggestion does not match up with the request in the original ticket (I split the link changes out into a separate ticket, hence different PR): https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2960843?src=WorkItemMention&src-action=artifact_link

Can you consult with @kleggMS and @henrymbuguakiarie to get agreement on wording? Thank you!

kengaderdus commented 2 months ago

@BenBagBag

What's not matching? Can you mention one instance or example.

What I said is, if you refer to the product name, use Microsoft Entra External ID, if you're referring to the CIAM tenant, use external tenant.

CC: @kleggMS

BenBagBag commented 2 months ago

@kengaderdus Ah, that makes sense, thanks for clarifying. I've updated it, please re-review.

CC: @kleggMS