search

Azure-Samples / ms-identity-java-webapp

A Java web application calling Microsoft graph that is secured using the Microsoft identity platform
MIT License
118 stars 105 forks source link

Revert samesite fix #41

Closed Avery-Dunn closed 4 years ago

Avery-Dunn commented 4 years ago

Reverting samesite changes in https://github.com/Azure-Samples/ms-identity-java-webapp/commit/53e4af22198e2bcc7a68ce3151b21962ebf2b086, as per https://github.com/Azure-Samples/ms-identity-java-webapi/issues/9

navyasric commented 4 years ago

@Avery-Dunn / @SomkaPe With this change to the sample, do we still need the HTTPS URLs and the steps to set up SSL certificate locally ? Can you update the Readme if necessary? Please also let me know since I would need to update the Quickstart docs as well.

Avery-Dunn commented 4 years ago

@navyasric: Sorry for the delay, but yes we still need the SSL certificate setup instructions. None of the HTTPS changes in the related commit were reverted, so the certificate is needed for the samples to be hosted on a secure connection.