Azure-Samples / ms-identity-javascript-react-tutorial

A chapterwise tutorial that will take you through the fundamentals of modern authentication with Microsoft identity platform in React using MSAL React

https://github.com/AzureAD/microsoft-authentication-library-for-js

MIT License

298 stars 276 forks source link

Edited the README.md of the 2-sign-in-b2c #423

Open NikolaBV opened 3 months ago

NikolaBV commented 3 months ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

Other Information

NikolaBV commented 3 months ago

Reason for pull request

The instructions do not match the file structure of the project.

This is what it currently says in the README:

readme1

readme2

While this is the contents of the Authorization folders:

Authorization 1 - folder authorization 1 - contents Authorization 2 - folder Authorization 2 - contents

None of them include the "2-sign-in-b2c\SPA" directory, while the "1-Authentication" folder contains exactly what is noted in the README.

Authentication - contents

With this pull request I have changed the file paths to the supposed correct ones.

Testing

I have tested the code and it runs as expected, all intended functionality works.