search

Azure-Samples / ms-identity-javascript-v2

VanillaJS sample using MSAL.js v2.x and OAuth 2.0 Authorization Code Flow with PKCE on Microsoft identity platform
MIT License
105 stars 84 forks source link

The reference document link in README.md is Implicit grant flow. #7

Closed g-child closed 4 years ago

g-child commented 4 years ago

In Readme.md line 55, The link to "For more information, see the documentation" in 1.3 of "Running the sample" is below, but this is the Quickstart of Implict grant Flow.

https://docs.microsoft.com/azure/active-directory/develop/quickstart-v2-javascript

The following authentication code flow Quickstart also exists, so it is better to change.

https://docs.microsoft.com/azure/active-directory/develop/quickstart-v2-javascript-auth-code

Can I create Pull Requests to fix link?

derisen commented 4 years ago

@g-child good catch! Please go ahead and make a PR if you like.

g-child commented 4 years ago

@derisen Can you review PR? I tried to set the reviewer to PR, but it doesn't seem to work with my account.