Azure-Samples / ms-identity-mobile-apple-swift-objc

An iOS sample in Swift that authenticates Microsoft Account and Azure AD users and calls the Graph API using OAuth 2.0
https://aka.ms/aaddev
74 stars 37 forks source link

update sample #38

Closed unpluggedk closed 5 years ago

unpluggedk commented 5 years ago

remove cartfile and update project to not use storyboard, and refactor for better grouping of functionalities.

antrix1989 commented 5 years ago

Looks good, the only comment: after installing pod, project is failing to compile with error:

Use of unresolved identifier 'MSALGlobalConfig'

Also, I think it is a good idea to specify exact MSAL pod version.

target 'MSALiOS' do
    pod 'MSAL', '0.4.0'
end

Otherwise sample may fail if latest MSAL pod is not compatible with sample code.