search

Azure-Samples / ms-identity-netcore-winui

Win UI with MSAL library
MIT License
12 stars 2 forks source link

WinUI sample #1

Closed aremo-ms closed 1 year ago

aremo-ms commented 1 year ago

Purpose

Demonstrate MSAL Authentication library used by WinUI sample to call MsGraph API

v-michaelmi commented 1 year ago

Nit:

There's still a section with [LINK FOR SURVEY HERE] written

In reply to: 1281369256

In reply to: 1281369256

In reply to: 1281369256

tonyYuhaoYangMcrS commented 1 year ago

The readme step "running the sample" has you run "dotnet run" from a shell or command line.

This currently does not work, should it be changed to specify that it can only be run from Visual Studio?

In reply to: 1281371145

In reply to: 1281371145

kalyankrishna1 commented 1 year ago

We recommend you familiarize yourself with Using certificates with Microsoft.Identity.Web as it provides various ways for a developer to use a certificate instead of a client secret to authenticate their apps with Azure AD.

this sample needs a section for MSAL.NET

In reply to: 1281574861

In reply to: 1281574861

In reply to: 1281574861

Refers to: AppCreationScripts/README-use-certificate.md:3 in 66eecfe. [](commit_id = 66eecfe287e96f790ceca2c55178b7630c05f0a9, deletion_comment = True)

kalyankrishna1 commented 1 year ago

Prerequisites

codegen should push updated text for this one too

In reply to: 1281584127

In reply to: 1281584127

In reply to: 1281584127

Refers to: README.md:52 in d304707. [](commit_id = d3047070d0eb667f17fb1c3b40126e641933cad7, deletion_comment = False)

kalyankrishna1 commented 1 year ago 
1. In the **Redirect URIs** | **Suggested Redirect URIs for public clients (mobile, desktop)** section, select **ms-appx-web://microsoft.aad.brokerplugin/{ClientId}**

this is not a "suggested" url in the portal for any app? what am I missing?

Also, anew dev might not know what the "ClientId" is and we need to explain, like copy the "clientId" from the overview blade and build this Url" or something like that

In reply to: 1281590115

In reply to: 1281590115

Refers to: README.md:130 in d304707. [](commit_id = d3047070d0eb667f17fb1c3b40126e641933cad7, deletion_comment = False)

kalyankrishna1 commented 1 year ago

Troubleshooting

I suppose we can remove this section

In reply to: 1281599284

In reply to: 1281599284

In reply to: 1281599284

Refers to: README.md:203 in d304707. [](commit_id = d3047070d0eb667f17fb1c3b40126e641933cad7, deletion_comment = False)

kalyankrishna1 commented 1 year ago

Learn more

Add a few standard ones like

  1. MSAL.NET
  2. App registration
  3. MS graph devloper page

and so on

In reply to: 1281601347

In reply to: 1281601347

In reply to: 1281601347

Refers to: README.md:375 in d304707. [](commit_id = d3047070d0eb667f17fb1c3b40126e641933cad7, deletion_comment = False)

aremo-ms commented 1 year ago

Nit:

There's still a section with [LINK FOR SURVEY HERE] written

Yes, added survey now

In reply to: 1281644014

kalyankrishna1 commented 1 year ago

get @bgavrilMS , is there a place where we documented the pre-requisites for WAM. It'd probably be one of the first questions to come by. @aremo-ms can add an additional section in readme to highlight that as well

In reply to: 1153005418

bgavrilMS commented 1 year ago

Yes there are 2:

See details here: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/wam#to-enable-wam-preview

In reply to: 1290421110

aremo-ms commented 1 year ago

@bgavrilMS I need a little bit help with getting Window Handle inside constructor, if it is possible at all. I'm trying to use WithParentActivityOrWindow method as part of Public Client creation. I saw the sample you've set us in previous comments, but I still have the challege Please advise.

My code currently: .WithBrokerPreview(true) .WithParentActivityOrWindow(new System.Windows.Interop.WindowInteropHelper(this).Handle)

@kalyankrishna1 please see what we can see

aremo-ms commented 1 year ago

@bgavrilMS @kalyankrishna1 I've came out with some solution. I need a confirmation if this is the correct solution