Azure-Samples / ms-identity-netcore-winui

Win UI with MSAL library
MIT License
12 stars 2 forks source link

Not applicable or relevat for WinUI 3 #11

Open matthewacme opened 3 months ago

matthewacme commented 3 months ago

This issue is for a: (mark with an x)

- [ X ] documentation issue or request

Minimal steps to reproduce

try to use this sample with a WinUI 3 project template, it just isn't applicable

Expected/desired behavior

OS and Version?

Windows 10, 11

Versions

WinUI 3 & .Net Core 8.0

Mention any other details that might be useful

Just one example of an issue.

consider the
.WithWindowsEmbeddedBrowserSupport() extension

Unfortunately that requires adding the Microsoft.Identity.Client.Desktop nuget package and currently when attempting to add that library to a WinUI 3 project you will get the following error:

The type 'CoreWebView2NavigationCompletedEventArgs' exists in both 'Microsoft.Web.WebView2.Core, Version=1.0.864.35, Culture=neutral, PublicKeyToken=2a8ab48044d2601e' and 'Microsoft.WinUI, Version=3.0.0.0, Culture=neutral, PublicKeyToken=de31ebe4ad15742b'

This is due to a namespace collision between the WebView2 system that is referenced in the nuget package and the WinUI 3 system which has its own integrated WebView2 system.