my org pull request - Githubissues

Azure-Samples / ms-identity-python-flask-webapp-authentication

This sample demonstrates a Python Flask webapp that signs in users in your tenant using Azure Active Directory

MIT License

55 stars 18 forks source link

my org pull request #1

Closed idg-sam closed 4 years ago

idg-sam commented 4 years ago

Purpose

it demonstrates authenticating users to one organization's AAD

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow instructions in readme

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]

ghost commented 4 years ago

All CLA requirements met.

idg-sam commented 4 years ago

The recent changes are mainly in the auth_endpoints file, the readme (how to set the project up, how to run it, and about the code), using https instead of http, adding a token details page, and an unauthoized 401 redirect when the user tries to access the /auth/token_details URL without being authenticated.

idg-sam commented 4 years ago

Some todos for the future:

add support for parsing and displaying AADSTS error codes to help developers debug their applications.
remove url_for and replace with absolute URLs from a config file. Users importing the auth_endpoints might have different function names.