jennyf19
commented
4 years ago left a few comments and questions, but overall, i think it looks pretty good. i assume you've tested it, but am surprised it works w/localhost, unless that just rolled out and b2c didn't tell us. :)
rayluo
The web app in this repo was originally developed to demonstrate behaviors in non-B2C scenario. With the current (
not-yet-merged) B2C implementation in MSAL Python (and its improvement), the MSAL Python API surface remains unchanged, so all those pre-existing behaviors just work in B2C. That means any existing MSAL-Python-powered web app can be used in B2C scenario without any source code adjustment. Just swap in a different set of configuration and it would work.In this PR, we did add several HTML links pointing to the B2C profile page and B2C reset password page. Such new adjustments all start with an
if config.get("B2C_something")statement, so they are self-documented and won't be confused with non-B2C scenarios.TODO: Somehow update the README to describe how to provide a set of configurations for B2C.We now also provide a new README_B2C.md to show how to run this sample in the B2C context. This page is derived from the existing ASP.Net tutorial page for web app using B2C. It also follows the guidance to "decouple ...sign-in... from API access at runtime", even though this sample itself does not serve as a web API.We also add a new
app_config_b2c.pyas a configuration template for B2C, so that it won't mess up with the pre-existing, non-B2Capp_config.py. The new configuration file also follows the guidance to "use a string variable for tenant name (contosob2c), and construct full authority host and tenant names at runtime".PS: This is not part of this sample or PR, but it is the high level B2C how-to wiki page in MSAL Python wiki.