search

Azure-Samples / openai-chat-app-quickstart

A simple chat application that uses managed identity for Azure OpenAI access. Designed for deployment on Azure Container Apps with the Azure Developer CLI.
MIT License
167 stars 103 forks source link

Update requirements.txt to skip uvloop on Windows machines #206

Closed dawnwages closed 1 month ago

dawnwages commented 1 month ago

Skips installing uvloop on Windows machines.

Purpose

uvloop doesn't support Windows

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

pip install -r src/requirements.txt on a windows machine

What to Check

Verify that the following are valid

Other Information

pamelafox commented 1 month ago

See https://github.com/Azure-Samples/openai-chat-app-quickstart/pull/193 for a PR for the issue and a discussion of the best approach. The author hasn't updated it per our discussed changes, so you could make the changes there, or I can make them when I have the chance.

pamelafox commented 1 month ago

I just merged a fix for this, thanks for reminding me about it!